Getting ripped off by lotto tickets

[D3athrow-Issues]

(WEB REPORT BY: blithering REMOTE: 206.221.180.138:7777)

Revision

53ed0ac186346646179fe36ac77ac710dddacae0

Description

Supermatter surprise tickets are supposedly a guaranteed win at the cost of a hand, but they can crop up no winners

Steps to Reproduce

have hands to spare, scratch off supermatter surprise card

What you Expected

money no hand

What Actually Happened

no money no hand

[Blithering]

[ancientpower]

@west3436

[west3436]

Either an issue from the luck additions or my (likely) improper use of prob(). I'll fix this next week

[ancientpower]

Either an issue from the luck additions or my (likely) improper use of prob(). I'll fix this next week

I tested the base luck procs and they work fine so it seems to be an issue with the values that you're passing them and the way that prize value is tied to probability. Also, what's up with the 1/12000 magic number for luckfactor? That's making any luck influence astronomically small.

[west3436]

Luck stuff was added after these were implemented and I had no hand in that change. Don't remember who added luck. I've been wanting to redactor these tickets anyways so I'll sort that portion out too.

[Eneocho]

Don't remember who added luck.

You want @Hinaichigo, he added the luck system. There is an explanation on luck mechanics on the wiki page for Luck.

[Hinaichigo]

I misunderstood the supermatter surprise code when I did the luck stuff. I'll see if I can fix it.

[Hinaichigo]

Also, what's up with the 1/12000 magic number for luckfactor? That's making any luck influence astronomically small.

When luck was merged it was initially considered way too easy to make lots of credits with scratchcards and clovers so it was nerfed a lot.

[west3436]

Fixed via #35287