vgstation-coders / vgstation13

Butts
GNU Affero General Public License v3.0
264 stars 543 forks source link

PDA from beyond the grave #34866

Closed Blithering closed 5 months ago

Blithering commented 1 year ago

Description of issue

PDA messaging checks if you're conscious etc. when you try to make a new message, but if you already had a window open, you're free to type your killer's name, your body's location on the asteroi or the fact that deadchat are currently debating waifus, and it will send just fine.

Difference between expected and actual behavior

Expect to be dead and not able to send messages. Actually lemme finish this text before I die.

Steps to reproduce

Open a PDA message input box Inspect the business end of a laser Continue typing post mortem, click send

[exploitable] [oversight] [sanity]

nervere commented 1 year ago

happens with every alert() or input() window #33888

There's not a universal patch that can be applied to this aside from adding proper sanity to these features when an issue is found. This PDA exploit is pretty funny tbh but that shuttle stuff sounds annoying.

Killette2 commented 1 year ago

My tactic of finally calling the shuttle the moment I die has been ruined