search

vgstation-coders / vgstation13

Butts
GNU General Public License v3.0
264 stars 541 forks source link

Chewing gum-covered shoes are blood-stained #34874

Open D3athrow-Issues opened 1 year ago

D3athrow-Issues commented 1 year ago

(WEB REPORT BY: tinysaturn REMOTE: 206.221.180.138:7777)

Revision

835fd60545178a19064f5df9981dac6e1b220775

Description

Blood-stain fix PR must have missed this

Hinaichigo commented 1 year ago

After some testing, when you step in chewing gum it doesn't have any stain description by itself. I think maybe you also had blood on your shoes and it just said blood since the gum wasn't included, but it became fully gum-colored since gum doesn't use the same thing for color mixing. I'll see about adding gum to the blood DNA.

Eneocho commented 1 year ago

@Hinaichigo Could you make it so the colour for the oil stain text is whiter for dark mode. It's kinda hard to read the very dark "oil stained" text on dark mode. It's a similar issue to #31894.

Hinaichigo commented 1 year ago

I think all we would have to do to fix that is increase DYNAMIC_TEXT_COLOR_V_MIN: https://github.com/vgstation-coders/vgstation13/blob/835fd60545178a19064f5df9981dac6e1b220775/__DEFINES/colors.dm#L10-L11

We can amp it up a bit but one thing is that making it brighter will also lower the contrast in lightmode, so it's a bit of a balancing act.

It'd be nice if there was a way to do it with two settings, one for darkmode and one for lightmode. But I'm not sure how to do that since the span class colors aren't defined in advance.

I think some browsers support stuff like that but not sure if the version of IE that BYOND uses does.

Eneocho commented 1 year ago

There is a separation between dark mode and light mode. For example, clown is bright yellow in dark mode, but mild pink in light mode, you can do that separation, though not really sure how that would work with the dynamic text stuff.