search

vgstation-coders / vgstation13

Butts
GNU Affero General Public License v3.0
265 stars 544 forks source link

Can't rig assembly to barrel #35029

Open Hinaichigo opened 1 year ago

Hinaichigo commented 1 year ago

Description of issue

You can't attach an assembly to make a bomb out of a barrel because is_open_container() returns true. @Eneocho @SECBATON-GRIFFON maybe you'll know the best way to fix this.

Difference between expected and actual behavior

Expected adding an assembly to a barrel to make it into a bomb. Actually can't attach assembly to barrel.

Steps to reproduce

Get assembly eg. igniter + remote signaler and try to attach it to the barrel

Specific information for locating

https://github.com/vgstation-coders/vgstation13/blob/3c144e015c4d7c52ab8d522d0a1fabc73d8274bc/code/modules/reagents/reagent_dispenser.dm#L57

[bugfix]

SECBATON-GRIFFON commented 8 months ago

oh i'm pretty sure i disabled it because it would turn cauldrons into bombs too, which would be odd.

Eneocho commented 8 months ago

barrels have the OPENCONTAINER flag https://github.com/vgstation-coders/vgstation13/blob/3c144e015c4d7c52ab8d522d0a1fabc73d8274bc/code/modules/reagents/reagent_dispenser.dm#L562-L567