Speeds up lights on at roundstart

SECBATON-GRIFFON commented 4 months ago

[performance][qol]

What this does

shaves up to 1 ~~1.3~~ 1.5 seconds off that new slower roundstart (roundstart being the actual beginning of the round with job and antag assignment) adds a server config option to have all lights on at the start of the round regardless of players, off by default incidentally closes #25817.

How it was tested

editing config file, starting the game, obsing as ghost

Changelog

:cl:

rscadd: Server config now has an option to turn all lights on at roundstart, off by default
tweak: Total roundstart time and lights on time is now printed to admins in-game
bugfix: Lights now instantly turn on at roundstart, instead of after a delay
bugfix: Lightswitches now use moody lights, so their overlay no longer renders above everything
bugfix: Roundstart now has up to 1.5 seconds less lag.
bugfix: Admin flicking all lights on and off is also better performing now
bugfix: Jukeboxes no longer reset song on lightswitch flicking

Theophrastus1 commented 4 months ago

the Return of Adam

SECBATON-GRIFFON commented 4 months ago

the Return of Adam

more like undoing whatever happened that caused it

angryturnip commented 4 months ago

adam...

west3436 commented 4 months ago

@SECBATON-GRIFFON fella if you're still changing your PR, bring it to draft so we don't need to waste my time reviewing it only for you to add ten new commits after it has been reviewed. This is not the first time you've done this and you're tiring dilt and I out!

SECBATON-GRIFFON commented 4 months ago

@SECBATON-GRIFFON fella if you're still changing your PR, bring it to draft so we don't need to waste my time reviewing it only for you to add ten new commits after it has been reviewed. This is not the first time you've done this and you're tiring dilt and I out!

wasn't sure this was a problem but i'll note it

SECBATON-GRIFFON commented 4 months ago

fun fact: theres still about half a second of lighting lag left if there's at least 1 player on with all the lights flicking on set in the config but if theres 0 players its instant, however commenting out the lighting subsystem update makes it instant with the 1 player at the cost of lights being a lil slower to flick on. worth noting

west3436 commented 3 months ago

@SECBATON-GRIFFON will merge after you fix conflicts

SECBATON-GRIFFON commented 3 months ago

@SECBATON-GRIFFON will merge after you fix conflicts

@west3436 done

vgstation-coders / vgstation13