vgstation-coders / vgstation13

Butts
GNU General Public License v3.0
260 stars 542 forks source link

Burning Mob Fix #36626

Closed west3436 closed 1 month ago

west3436 commented 1 month ago

What this does

Fixes mobs taking no/very little damage while standing in fires.

Why it's good

Fire rework decoupled the subjective "fire_level" var from all fires except for plasmafires. The FireBurn proc which is called on mobs used this value which is always 0 for non-plasmafires, so mobs were not being damaged at all. Additionally, the temperature fed into the calculation used the ambient temperature rather than the flame temperature, so even at a higher firelevel mobs would still not be damaged at all unless the fire was already massive.

How it was tested

Walked through and stood in a burning fire and adjusted the damage ratio to be similar to what it was prior to fire rework.

Changelog

:cl: