vgstation-coders / vgstation13

Butts
GNU General Public License v3.0
260 stars 542 forks source link

Some subsystem init speedups #36632

Open SECBATON-GRIFFON opened 1 month ago

SECBATON-GRIFFON commented 1 month ago

[performance]

What this does

rewrites the lighting subsystem to search by area first, skip ones without dynamic lighting, and then search the turfs in the area to apply it to, cutting down the time by half (0.5 seconds) while applying the same logic moves mining suprises into the skip vaults thing if set in the config addresses #36631 by cutting down object init by 1.2 seconds from that and 1.7 in total 2.2 seconds shaved overall

How it was tested

booting up tgstation.dmm

Changelog

:cl:

Eneocho commented 1 month ago

kanef roams free with init speedup PRs while my homie adam is still held prisoner by the powers that be... we truly do live in a society... we live in a soycity

boy2mantwicethefam commented 1 month ago

If the skip vaults config is the one that disables vaults from spawning then it might not have a real impact on live improvements.

SECBATON-GRIFFON commented 1 month ago

If the skip vaults config is the one that disables vaults from spawning then it might not have a real impact on live improvements.

that's why i didn't factor it into the time i posted

SonixApache commented 4 weeks ago

prepare for unforeseen consequences