Vendor coinbox and vendpack qol

SECBATON-GRIFFON commented 3 weeks ago

[qol][bugfix]

What this does

allows vendpacks and coinboxes to come out of vendors on crowbar destruction and not just explosions or blobs. fixes coinboxes not coming out anymore at all. allows coinboxes to be recycled in smelters and the autolathe and etc. to compensate this, their frames now need coinboxes as a component part, and can be built from 1 sheet of metal, but with no access requirements like roundstart vendors have. Closes #9892.

Why it's good

stops coinboxes from being duplicated indefinitely and occupying space.

How it was tested

calling ex_act on the vendors, screwdriver and crowbar destroying them, and putting them back together and screwdriving it to completion.

Changelog

:cl:

bugfix: Coinboxes can now come out of vending machines again.
tweak: Coinboxes and vendpacks now eject from crowbar destroying vending machines. Vendpacks still require inserted cardboard for this.
tweak: Coinboxes can now be recycled for metal, under the electronics category.
tweak: To compensate coinboxes being recyclable, and as to not be an infinite metal source, they are now required in their frame build step. A no access requirement version of them can be built as a metal stack recipe to aid this.

hacker-on-steroids commented 3 weeks ago

~vendpacks should only come out if you put cardboard sheets into the vendor~ disregard i suck cocks i didnt even read all the code

SECBATON-GRIFFON commented 3 weeks ago

vendpacks should only come out if you put cardboard sheets into the vendor

that still functions like that, i reused the proc

Eneocho commented 3 weeks ago

coinboxes return

ok pomf I take it back do not release this man, keep him imprisoned

Eneocho commented 3 weeks ago

do we even need to have a coinbox? why not just spit out all coins immediately upon disassembly

SECBATON-GRIFFON commented 3 weeks ago

coinboxes return

ok pomf I take it back do not release this man, keep him imprisoned

they only vanished due to a bug, really

Eneocho commented 3 weeks ago

Goes to show how much people disliked them that it took years for someone to notice and try to bugfix it. Please don't restore the coinboxes, remove them altogether. You sometimes build and rebuild vendors for various reasons, and having to deal with the coinboxes is a hassle. Not to mention that extra metal cost. If you rebuild a vendor you disassembled, you HAVE to add some metal, instead of being able to slot in the old coinbox. Just let dead features rest in peace, man. Coinboxes were a terrible feature.

SECBATON-GRIFFON commented 3 weeks ago

If you rebuild a vendor you disassembled, you HAVE to add some metal, instead of being able to slot in the old coinbox.

i was debating making it like this but it would've involved coming up with a way to build them, like the autolathe, and i wasn't a fan of that

Just let dead features rest in peace, man. Coinboxes were a terrible feature.

recyclability makes them a bit less terrible, we'll see how it pans out

Eneocho commented 3 weeks ago

I still don't like the idea of the return of coinboxes, I hate them with a passion, but if they are returning (and initial votes suggest they will), consider this: -Coinboxes are craftable from the metal sheet menu (like chairs or tables) and the assembly asks for a coinbox directly, instead of a metal sheet. -Remove the access check on the coinboxes altogether. That way you don't have to do a roundabout way of removing the metal sheet on disassembly, while still keeping the extra cost for a coinbox, unless you're reusing a coinbox, which saves you that sheet. Only the QM and Captain/HoP had legitimate access to open the coinboxes, making them useless for most of the crew on most of the rounds, and it's not like you could ask the HoP for QM level access to get to the coinboxes, since that'd mean you'd be getting actual QM access as well. Also please consider respriting the coinboxes; they're ugly and doesn't make sense to have such fuckhuge coinboxes in a credit-based economy where coins are rarely used.

hacker-on-steroids commented 3 weeks ago

what sneedeocho said minus the access part

SECBATON-GRIFFON commented 3 weeks ago

-Coinboxes are craftable from the metal sheet menu (like chairs or tables) and the assembly asks for a coinbox directly, instead of a metal sheet.

done

-Remove the access check on the coinboxes altogether.

only for ones built this way.

SECBATON-GRIFFON commented 3 weeks ago

also its out of scope but i wish the cash from a vendor went into the coinboxes too, would make them a bit more useful...

vgstation-coders / vgstation13