Changes to projectiles, lightning and some fixes

[boy2mantwicethefam]

Fixes #36665

It's unatomic. Sorry for the scopecreep, it started off by merely trying to make it so that point blank shots always hit.

• Guns can now support chances to miss, currently only applied to the XCOM laser weapons during April Fools Day.
• Guns and projectiles can also support unique missing messages.
• Improved the Stormtrooper rifle so that when it misses it actually misses.
• Point blank shots (attacking someone in melee range while on harm intent with a gun) will no longer miss a target unless you are in a vehicle (vehicles actually cause an accuracy penalty, making it more likely to miss shots while driving and nullifying any accuracy advantage, this is already in the game).
• You can no longer hit missing limbs, instead they will simply miss, with feedback message regarding which limb was missed.
• Fixed an at least 4 years old bug where laser hits were not producing a hit message when hitting a target.
• Fixed lightning so that the graphics are properly rendered (this is entirely thanks to ApotheoticOrder).
• Fixed lightning code so that bots and mechas can now be properly affected, not only damaged but also arced to. Removed unnecessary glow orb limit, especially because they have an unique interaction when exposed to lightnings and tasers. Lightning will no longer arc if it hit an obstacle, such as a wall, and should remove incidents of Lightning passing through walls.
• The EMP effect of lightning has been made more severe.
• Wizards can no longer cast Lightning on themselves.
• Removed the eye blurriness and stuttering effects from wizard Lightning.
• Added an "excessive missing" variable for both guns and projectiles, which will make it significantly more likely to completely miss a target by making it guaranteed to select the "missed target" RNG roll, and it also makes it possible to miss stationary targets. The stormtrooper rifle benefits from this, but so can badmemes.

Known bugs: There is a degree of separation between where the Lightning sprite shows it hits and where it actually hits. Not sure how I can fix this but it is an improvement over the sprites being broken.

Also fixed an exploit that allows one to infinitely stack gun projectile damage by repeatedly trying to fire at someone in point-blank while not having the dexterity to do it (such as through boxing gloves), and then regaining dexterity to fire an extremely damage-stacked projectile. This is caused by point blank fire changes happening really early and not getting reset if the Fire() proc happens. The fix is resetting it whenever the Fire() proc returns a normal value.

:cl:

• rscadd: The laser pistol and laser rifle from R&D now have extremely poor accuracy during April Fools.
• rscadd: Added a few variables that admins might find useful, related to ranged weapon accuracy.
• bugfix: Fixed an at least 4 years old bug where lasers did not say what living entity they've hit.
• bugfix: (ApotheoticOrder provided the fix) Fixed the Lightning effects such as from the wizard's spell or the traitor's power gloves, the sprites will now properly show up. There is still a bug where the visuals do not line up in some circumstances with the target but it is a vast improvement over nothing.
• bugfix: The Lightning wizard spell will now properly target bots and mechas.
• bugfix: Wizards can no longer cast Lightning on themselves, which didn't do anything because they are immune to their own Lightning.
• bugfix: Fixed an exploit where a gun could have unlimited damage by repeatedly attempting to perform point-blank shots with a ballistic weapon while not actually being able to fire the gun, such as through wearing boxing gloves, and then firing the weapon.
• tweak: Hitting a missing limb with a projectile will no longer hit the target, but instead display a missing message and what limb is missing.
• tweak: Improved the Stormtrooper Blaster Rifle's ability to miss its targets.
• tweak: The EMP effect from the Lightning spell is now more severe.
• tweak: The Lightning spell will no longer cause blurriness and stuttering.
• tweak: The Lightning spell will no longer chain arc to other targets if it hits something that isn't a valid target. That means no random lightning through walls!
• tweak: Point blank shots now have an accuracy boost, such that under normal conditions they should never miss.

[SECBATON-GRIFFON]

does this close #36665?

[boy2mantwicethefam]

Yes, kinda. Being in a vehicle or using a weapon that is likely to miss can still cause it to narrowly miss at point-blank.

[SECBATON-GRIFFON]

Yes, kinda. Being in a vehicle or using a weapon that is likely to miss can still cause it to narrowly miss at point-blank.

if its the stormtrooper y ones then fair i guess