search

vgstation-coders / vgstation13

Butts
GNU General Public License v3.0
260 stars 541 forks source link

FIXES BAGULOOSE QUICK EQUIP EXPLOIT #36676

Closed SECBATON-GRIFFON closed 2 weeks ago

SECBATON-GRIFFON commented 3 weeks ago

[bugfix][ITSLOOSE]

What this does

Closes #36674.

How it was tested

clicking the bag with the other bag, and quick equipping.

Changelog

:cl:

boy2mantwicethefam commented 3 weeks ago

I think it might be worth looking into blacklisting bags of holding from being quick-equipped into other bags of holding in order to prevent a reckless quick-equip command from unintentionally baguloosing.

SECBATON-GRIFFON commented 3 weeks ago

I think it might be worth looking into blacklisting bags of holding from being quick-equipped into other bags of holding in order to prevent a reckless quick-equip command from unintentionally baguloosing.

skill issue

boy2mantwicethefam commented 3 weeks ago

I mean it is funny but a blacklist would be mostly in order to avoid people from getting banned for unintentionally baguloosing

Dacendeth commented 3 weeks ago

I think it's more important to prevent it so people intentionally griefing cant use it as an excuse.

hacker-on-steroids commented 3 weeks ago

blacklist welding fuel tanks so people don't get banned for accidentally welderbombing

nervere commented 2 weeks ago

It really should be under Click(), you just know some admin is going to ban/note a guy for an accidental baguloose.

jwhitak commented 2 weeks ago

I will merge this because stopping bags of holding going inside bags of holding is probably more important than having people... accidently end the round by pushing a hotkey by mistake? Yeah, someone can change this to click() later if it actually happens (it probably will).

SECBATON-GRIFFON commented 2 weeks ago

I will merge this because stopping bags of holding going inside bags of holding is probably more important than having people... accidently end the round by pushing a hotkey by mistake? Yeah, someone can change this to click() later if it actually happens (it probably will).

i think admin logging that would be better, maybe with a "last time this hotkey was pressed" situation