search

vgstation-coders / vgstation13

Butts
GNU General Public License v3.0
260 stars 541 forks source link

Pauses more subsystems during explosions #36693

Closed SECBATON-GRIFFON closed 1 week ago

SECBATON-GRIFFON commented 2 weeks ago

[performance]

What this does

pauses the air, pipeline, burnable and power subsystems during them as well as lighting, which was already being paused

Why it's good

cuts down the time it takes by over half, with nukes

How it was tested

nuke sized explosion, 3 times on 3 different startups, set off where the AI core would spawn in on box station. down from 40 seconds average to 15-16 seconds.

## DEBUG: Explosion(226,241,1)(d30,h60,l120): Took 15.2 seconds.
## DEBUG: Explosion(226,241,1)(d30,h60,l120): Took 16.3 seconds.

Changelog

:cl:

malfunctioning-ai commented 2 weeks ago

This will surely have no larger ramnifications

boy2mantwicethefam commented 2 weeks ago

Doesn't sound bad. Air should probably be paused because of the hole an explosion could leave in the station.

angryturnip commented 2 weeks ago

Could you make this something toggleable for admins in the event of unforeseen consequences?

jwhitak commented 1 week ago

If this causes issues on live from spammed explosions, we can quickly revert this.

SECBATON-GRIFFON commented 1 week ago

If this causes issues on live from spammed explosions, we can quickly revert this.

lighting would have already in the pre PR code, plus explosions with devs below 4 don't postpone anything in these calcs.