vgstation-coders / vgstation13

Butts
GNU General Public License v3.0
260 stars 541 forks source link

Disables Contract of Apprenticeship during Civil War of Casters #36697

Open boy2mantwicethefam opened 2 weeks ago

boy2mantwicethefam commented 2 weeks ago

Apprentices are pretty broken on the code side of things when it comes to being handled by the CWC faction code.

On top of that when there's already 4 wizards and then someone sends another 5-6 wizards to cause mayhem it leads to the sort of gunk that got Summon Guns banned from anything that isn't a roundstart wizard. Why is the Wizards Federation sending apprentices into the civil war now? Let them have their own fight! Every apprentice caught in the bloodshed is an apprentice that won't become a proper wizard. Plus it leads to a lot of friendly fire because the apprentices don't actually share the CWC faction so they can't tell who's an ally. I've seen pitbulls and other creatures summoned by mages attack their own apprentices because of this.

Does not affect midround wizards.

:cl:

Eneocho commented 2 weeks ago

I so fucking hate that kurf got rid of the funny tags, this desperately needed an I DED tag.

boy2mantwicethefam commented 2 weeks ago

I'm not doing this out of salt, I just think it gets really messed up and there's a lot of accidental ban-baiting in the process. Imagine if the apprentice of a wizard fireballed a member of the civil war faction that the apprentice's master was part of, the apprentice has no way of knowing it because the apprentice is not technically part of the civil war, but it's probably grounds for a punishment from an admin even though they have no way of telling who's part of what. I made a PR to try to fix it (#36698) but I'm not sure if it actually works because multiple accounts on a self-hosted server do not work on my machine.

Eneocho commented 2 weeks ago

fair enough still, I do miss the funny tags like "i ded" or "cannot reproduce"

jwhitak commented 1 week ago

We'll try the other solution first, where it attempts to join them to the correct factions.