Open SECBATON-GRIFFON opened 1 week ago
Ore bags no longer have exploitably large capacities from dumping them and picking their contents up again. To compensate, their intended total ore stack amount total has been increased from 166 (normally resulting from 33 mined pieces inserted) to 700 (as ores stack to 100 total, so now 140 pieces can be fit inside this)
It isn't exploiting. The ores can naturally stack to 50, but didn't stack properly when bagged, the bag just held 50 stacks of 3 ore pieces, instead of stacking them into 3 stacks of 50 ore pieces each. By dropping the contents you are stacking them manually (like if you dragged an iron ore around and picked up all the surrounding iron ore), which makes the stacks function as intended. You're hiding the true nerf of this PR, cause you're literally reducing the total capacity from 2500 total ores (50 stacks of 50 ore) to 700. This is NOT a buff from 166 to 700, this is a nerf from 2500 to 700, a 72% reduction in capacity.
You're hiding the true nerf of this PR, cause you're literally reducing the total capacity from 2500 total ores (50 stacks of 50 ore) to 700. This is NOT a buff from 166 to 700, this is a nerf from 2500 to 700, a 72% reduction in capacity.
i tried wording it as best as i could, with "intended", but yes it is a nerf. if you want me to bump it back to 2500 then ill accept that.
The "dump the bag and pick the ores up" trick to properly stack them is standard minertech, meaning that the 2500 capacity is the expected actual capacity of an orebag for miners. Do not nerf the thing, please. Just fix the bug that didn't allow them to stack properly.
The "dump the ore and pick it up" trick to properly stack the ores is standard minertech, meaning that the 2500 capacity is the expected actual capacity for miners. Do not nerf the thing, please. Just fix the bug that didn't allow them to stack properly.
okay fine, you get your way, probably a lot of players too. updated it.
Many thanks. Apologies if I was a bit hostile.
~i think the lower capacity is fine~ ~if you want gigafuck amounts of ore drag an ore box~
actually i don't have a strong opinion about this because mining sucks
[bugfix][qol]
What this does
changes how stacks are placed into bags, making them stack automatically if possible. removes all the snowflake code for sheet snatchers since this system they used now works in general with new code. Closes #27141. Closes #32857.
Why it's good
makes putting stacks in bags nicer.
How it was tested
putting stacks into bags, examining their numbers on things that allow it; specifically the ore loaders, also picking up ore off the ground with them.
Changelog
:cl: