Some on_hit fixes - Githubissues

boy2mantwicethefam commented 5 days ago

Updates some on_hit effects so that they properly get blocked when they should be blocked, which means that martians carrying 5 or 6 riot shields can now menace the station. The most important part of this change is that it fixes on_hit so that it never happens to silicons, as it was intended and which was broken for about 5 years. Fixed Force Wall causing a projectile fired into it to not only hit everyone in the force wall but also apply on_hit effects regardless of protection. PROJECTILE_COLLISION_BLOCKED has a value of 2. Added a new projectile proc, robot_on_hit, which is called by silicons. By default it calls regular on_hit which will get blocked, but it can be overridden in order to allow projectiles to do unique robot effects, should the need arise. Tasers now slow down cyborgs this way.

:cl:

bugfix: Martians will now properly block projectile effects using their shields.
bugfix: Fixed a few instances in the code where having full protection against a projectile attack would still cause projectile effects to happen, even when it should be completely blocked.
bugfix: Fixed a 5-year-old bug where silicons were unintentionally subjected to various projectile effects such as syringes from syringe guns. However, they have retained their weakness to slowdown caused by tasers.
bugfix: Force Wall will now only pick one character on its turf to deal damage to if it is impacted by a projectile, as opposed to affecting every single character, and will now respect whether the user could block the attack or not.

Eneocho commented 5 days ago

Bugfix? Good Buffing silicons against tasers? Bad Please make it so tasers into sillycones still work as expected, or just remove that chunk, cause slowed down borgs or drunk borgs is a fun and relatively harmless interaction in the large scheme of things.

boy2mantwicethefam commented 5 days ago

I'll fix the tasers but not the "drunkeness" which doesn't actually happen for borgs from what I recall.

boy2mantwicethefam commented 5 days ago

Tasers are fixed.

Dacendeth commented 5 days ago

Better still be able to tackle borgs too.

boy2mantwicethefam commented 5 days ago

Tackling should be intact.

hacker-on-steroids commented 4 days ago

urrr how was this pr tested ?? ?

boy2mantwicethefam commented 3 days ago

@hacker-on-steroids I didn't, but I might.

vgstation-coders / vgstation13

Some on_hit fixes #36741