search

vgstation-coders / vgstation13

Butts
GNU Affero General Public License v3.0
265 stars 546 forks source link

Blending Unit Test Randomly Fails #36755

Closed jwhitak closed 2 months ago

jwhitak commented 3 months ago

Description of issue

Occasionally the blending unit test will fail due to /obj/item/weapon/reagent_containers/food/drinks/soda_cans/artifact/bad spawning with an amount of reagents considerably larger than what the mortar/aio grinder can hold.

For @SECBATON-GRIFFON

Difference between expected and actual behavior

Expected: blend test passes with arbitarily large volume inputs Actual: test can fail with a large input

Steps to reproduce

1) Attempt unit test multiple times 2) Eventually, a large volume soda can artifact will generate and give a message similar to the following:

UNIT TEST FAIL: /datum/unit_test/grind_juice 2s
    REASON #1: Reagent ID aluminum was not created to 5.05555 units from grinding /obj/item/weapon/reagent_containers/food/drinks/soda_cans/artifact/bad in the mortar. (got 3.05555)

Specific information for locating

blend_juice.dm likely needs to have mortar M and grinder R beaker volumes adjusted to a large number

Length of time in which bug has been known to occur

After merge of #36617

Server revision

SECBATON-GRIFFON commented 3 months ago

oh yeah, encountered this before and forgot about it. will work on it question is, change the logic so that the result comes out before transfer in full or change the test to account for this?

SECBATON-GRIFFON commented 2 months ago

revert closed it