vgstation-coders / vgstation13

Butts
GNU Affero General Public License v3.0
266 stars 546 forks source link

Thermostat Fixes #37000

Closed jwhitak closed 1 month ago

jwhitak commented 1 month ago

They were broken?

yes. yes they were.

What this does

Fixes thermostats so that their controls actually do something now besides make an indefinite clicking noise. The following are a list of the changes:

Why it's good

I want it warm in my leather making hotroom (thermostats set to 40C, the default maximum, can't get the room warm enough to cure leather quickly...), and I want it cold in the kitchen backroom, like it should be.

How it was tested

The usual - opening up ye olde test server and playing around with all the changes. Heating and cooling arbitarily, trying to set it to 0C to freeze to death, then changing the threshold presets to let me really up the thermostat and cure leather. Before: image After: image

Changelog

:cl:

SECBATON-GRIFFON commented 1 month ago

who touched the thermostat

toomykins commented 1 month ago

amazingly good fix. hope this also miraculously fixes #35711

jwhitak commented 1 month ago

The control range is that the air alarm's heating/cooling will turn on if it exceeds 2C of the desired temperature, and turn off if it's within 0.5C of the desired temperature. The amount heated/cooled scales based on the difference in desired/actual temperature, and the heat capacity of the gas sample taken.