search

vgstation-coders / vgstation13

Butts
GNU Affero General Public License v3.0
265 stars 546 forks source link

Pulse demons firing at times when they die immediately #37097

Open D3athrow-Issues opened 1 month ago

D3athrow-Issues commented 1 month ago

(WEB REPORT BY: angryturnip REMOTE: 172.93.101.77:7777)

Revision

cbe63e707222c364869bfb7a233a60a0912e2410

Byond Version

515.1636

Description

Happened to someone else and I got on to respond to their ahelp, but they latejoined as a pulse demon, spawned on a wire, but because the (fully charged) SMEs were set so their output was off, he immediately died. Should probably take that into account when firing pulse demon and not just whether or not the SMEs are charged. Take this bug report with a grain of salt as it didn't directly happen to me, but as best I can tell that's the reason the player died immediately upon spawning.

Steps to Reproduce

Latejoin and hit yes when the game asks if you want to be a pulse demon

What you Expected

Player agency

What Actually Happened

Immediate death

boy2mantwicethefam commented 1 month ago

They're supposed to spawn on powered exposed cables according to the code. However, there is a room for error (about 60 seconds while the midround pulse demon wants to join, or however as long someone waits before pressing "yes" on the latejoin prompt) where the pulse demon can still spawn on those cables if the SMES are turned off after the ready() check for the ruleset, which can cause the pulse demon to spawn on a powerless station.