search

vgstation-coders / vgstation13

Butts
GNU Affero General Public License v3.0
266 stars 546 forks source link

Air Alarms don't reset when they reach the optimal atmos value #44

Closed frangi closed 11 years ago

frangi commented 11 years ago
  1. Trigger an Air alarm
  2. Ripristinate atmos in that area
  3. Alarm still flashes yellow
d3athrow commented 11 years ago

Seems to be working fine for me on the server.

frangi commented 11 years ago

The alarm itsels says there's no warning, but the icon is still yellow. Just cause a small plasma leak somewhere, the alarm will be yellow. Use air scrubbers and after a bit if you check the air alarm it says everything is fine, but it's yellow.

d3athrow commented 11 years ago

The danger level needs to be zero for it to reset itself automatically and go back to green, this accounts for the entire area, not just that single room.

frangi commented 11 years ago

What does danger level 0 translate to? Because even if the air alarm shows "optimal", the icon doesn't update. This bug is present even in /tg/code.

d3athrow commented 11 years ago

Zero is every single thing checked by the air alarm is within the min1 and max1 boundries One is something has gone below min1, or above max1 2 is something has gone below min2, or above max2

Zero is green(optimal), one is yellow(minor), two is red(major).

frangi commented 11 years ago

And what I'm telling you, is that if you fuck up the atmos in an area, and then bring it back to "optimal", the air alarm doesn't update its icon.

d3athrow commented 11 years ago

I forgot to reference this, it was fixed in e8dd52bcfcc472110e8e320f63aab7963844335c