search

vgteam / graph-genomics-review

Pangenome graphs (review article on graph-based pangenomic methods)
70 stars 24 forks source link

Figures #65

Closed cartoonist closed 4 years ago

cartoonist commented 4 years ago

I have added a beautified version of Figure 1. Based on our brief discussion (me and @ekg), I also added a figure schematically illustrates data structures for pangenome representation (based on Fig 3 of CPANG without sequencing details). But I am not sure how to put it as a single figure. Therefore, I included all I have to decide the final setting here and also get some feedback.

ekg commented 4 years ago

These are really good!

I have two hopefully trivial suggestions. First, I thought that red and green could be difficult for colorblind readers. But looking at your images in grayscale suggests that you've already selected a good palette.

data_structures svg grayscale

If you think it might help to change, I'm partial to this one: http://colorbrewer2.org/#type=qualitative&scheme=Dark2&n=6

For the data structures one, I think we can have the collection of sequences and MSA smaller at the top, with the collection to the left and the MSA to the right. I didn't try it out though. What do you think?

BigNoodleTitling looks good. Is it licensed freely so that we can use it in the paper?

ekg commented 4 years ago

I've merged just to keep the content in master. Feel free to push another update.