search

vgteam / gssw

efficient alignment of strings to partially ordered string graphs
33 stars 17 forks source link

Fix end bonus edge cases #14

Closed adamnovak closed 7 years ago

adamnovak commented 7 years ago

Reads of a single base were only getting one end bonus. Now they get two.

Reads that had their last base as the first base of a node were crashing the traceback, because the traceback across nodes didn't handle end bonuses. Now it does.

ekg commented 7 years ago

Would you test and integrate this in vg? I'm getting errors with the previous version. Will try this out and see if it resolves them.

error:[gssw] Could not find a valid previous node
vg: src/gssw.c:3338: gssw_graph_trace_back_internal: Assertion `0' failed.
ekg commented 7 years ago

I'm testing this on a possibly-busted branch, so this isn't a very scientific assessment, but this PR does seem to have fixed this problem I mentioned here.