search

vgteam / libhandlegraph

Library for the Handle Graph abstraction
MIT License
21 stars 5 forks source link

Add overridable methods for total edges and total length #35

Closed adamnovak closed 4 years ago

adamnovak commented 5 years ago

Some implementations (vg, xg) internally know how many edges and/or bases are in the graph. This adds methods that can be used to ask those questions, with default implementations that do linear scans through the basic handle API.

jeizenga commented 5 years ago

Good idea. Any plans to add this to the libbdsg implementations?

adamnovak commented 5 years ago

Not until it stops weirdly breaking the vg build, sadly. But yes, we would want to add it to all of those that actually could support it simply.

On 11/27/19, Jordan Eizenga notifications@github.com wrote:

Good idea. Any plans to add this to the libbdsg implementation?

-- You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub: https://github.com/vgteam/libhandlegraph/pull/35#issuecomment-559217301

glennhickey commented 5 years ago

Changes to libhandlegraph interface are tough to integrate into vg, in my experience. Having conflicting versions used in different parts of the build often don't cause trouble until they corrupt a function pointer on Mac Travis in an obscure unit test. Speaking of Travis, its cache seems to do everything it can to make sure that this happens as much as possible.

On Wed, Nov 27, 2019 at 7:49 PM Adam Novak notifications@github.com wrote:

Not until it stops weirdly breaking the vg build, sadly. But yes, we would want to add it to all of those that actually could support it simply.

On 11/27/19, Jordan Eizenga notifications@github.com wrote:

Good idea. Any plans to add this to the libbdsg implementation?

-- You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub: https://github.com/vgteam/libhandlegraph/pull/35#issuecomment-559217301

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/vgteam/libhandlegraph/pull/35?email_source=notifications&email_token=AAG373UGNNDK4ZFG6E7QFUDQV4IR5A5CNFSM4JSK6JCKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFLDSUY#issuecomment-559298899, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAG373TLNFWANLURUICHU3TQV4IR5ANCNFSM4JSK6JCA .