search

vgteam / libhandlegraph

Library for the Handle Graph abstraction
MIT License
20 stars 3 forks source link

edge_index doesn't say if the edge has to be canonical or not. #40

Open adamnovak opened 4 years ago

adamnovak commented 4 years ago

VectorizableHandleGraph::edge_index should state that the edge_t has to be from for_each_edgeor edge_handle (i.e. in canonical order and orientation).

jeizenga commented 4 years ago

Seems to me it should be pretty easy to canonicalize internally

adamnovak commented 4 years ago

It kind of depends on if we want people to construct their own edge_t values ever, or if they are supposed to be opaque like handles.

Since there's no accessors into them other than .first and .second, I guess we should actually regard them as non-opaque and canonicalize the input edges.