Closed adamnovak closed 7 months ago
We have two concepts of a dataPath
: the one at the top level of config.json
which specifies where to find the exampleData
directory (and which we still use), and the one inside the ViewTarget
(which doesn't seem to be used anymore).
We want to get rid of the one that is inside of a view target/data source, and keep only the concept of a top level config dataPath
which is just where all the example data lives.
So we want to keep:
dataPath
in the READMEAnd we want to get rid of:
dataPath
entries in DATA_SOURCES
like: https://github.com/vgteam/sequenceTubeMap/blob/f4ab3c27dd53fc0ce0627d6a4885269378eb75ba/src/config.json#L10dataPath
in the comment here: https://github.com/vgteam/sequenceTubeMap/blob/f4ab3c27dd53fc0ce0627d6a4885269378eb75ba/src/App.js#L70-L72dataPath
field in the expected link for the tests here: https://github.com/vgteam/sequenceTubeMap/blob/f4ab3c27dd53fc0ce0627d6a4885269378eb75ba/src/end-to-end.test.js#L342
We no longer use the
dataPath
field on view targets, but it is still set on the examples inconfig.js
and still checked in the link to view tests. We should get rid of it and only use the one globaldataPath
.