search

vgteam / vg

tools for working with genome variation graphs
https://biostars.org/tag/vg/
Other
1.1k stars 194 forks source link

Remove protobuf as a submodule and move to system provided libraries. #1058

Open JervenBolleman opened 7 years ago

JervenBolleman commented 7 years ago

This requires protobuf 3 or higher, and is therefore dependant on travis supporting ubuntu 18.04 which is the next LTS release. Expected to be standard on travis in 2019.

For the other developers one can test if protoc is version 3 or higher in the makefile. While also requiring a libprotobuf.a normally in /usr/lib64/. Given these two files we can symlink these to the output locations of the protobuf build on a relevant machine.

homebrew has 3.4.1 available which is sufficient for vg. ports needs the package protobuf3. there is a ppa for protobuf3 on ubuntu

sudo add-apt-repository ppa:maarten-fonville/protobuf
sudo apt-get update
JervenBolleman commented 7 years ago

Unfortunately, that ppa does not have a protobuf3 for trusty :( leaving this as work in progress see also branch "dieprotobufcompile" in my repo