search

vgteam / xg

xg0: a simpler xg index
Other
5 stars 4 forks source link

Creating XG from GFA takes a very long time for graphs whose IDs do not start at 1 #2

Open jeizenga opened 5 years ago

jeizenga commented 5 years ago

I think the culprit is this line: https://github.com/vgteam/xg/blob/master/src/xg.cpp#L591

ekg commented 5 years ago

Yes, that's why. This call will pad the id space. It needs to start at a low number and be mostly contiguous for this to work comfortably.

There are many ways to fix this. A translation into the index space is one mechanism that would be quick to implement.

On Wed, Jun 19, 2019, 22:03 Jordan Eizenga notifications@github.com wrote:

I think the culprit is this line: https://github.com/vgteam/xg/blob/master/src/xg.cpp#L591

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/vgteam/xg/issues/2?email_source=notifications&email_token=AABDQENWGDZMDJDXTJXSU3DP3KGI7A5CNFSM4HZM4UH2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4G2PTG5Q, or mute the thread https://github.com/notifications/unsubscribe-auth/AABDQEKLVHL35LX77B5Y3WLP3KGI7ANCNFSM4HZM4UHQ .