search

vguillou / parallax-element

A Polymer element allowing to declaratively create simple vertical or horizontal parallax scrolling effects, working on desktop and mobile. It features built-in deactivation of the effect in browsers (IE) that do not fully support the CSS transformations leveraged to achieve the parallax scrolling.
MIT License
24 stars 2 forks source link

Polymer Starter Kit Error. #1

Closed samcarecho closed 8 years ago

samcarecho commented 8 years ago

After adding parallax-element to the latest version of Polymer Starter Kit (PSK v1.1.1 - Polymer V1.2.0), the following error shows in the console. Might this be a bug?

https://gist.github.com/samcarecho/4cc6b7a7eff9bff30779

vguillou commented 8 years ago

Hello!

I couldn't reproduce this issue. Could you provide more context/snippets ? I also ran the demos with the latests dependencies, including the paper-scroll-header-panel demo (source), and it works properly.

Polymer Starter Kit being based on a <paper-scroller-header-panel>, i recommend that you take a look at this demo and try to implement it the same way. I'll try whenever i find the time in the coming weeks.

Keep me up to date ! :ok_hand:

vguillou commented 8 years ago

So I've been busy testing the integration into Polymer Starter Kit 1.2.0, and it went well. Here is what I came up with : here

To sum it up, I took all the main content of the paper-drawer and made a new component for it. This way, I could use the ParallaxScrollerBehavior to make the paper-scroll-header-panel condense properly when scrolling. Of course, it also involve moving around a bit of JS and CSS. Take a look at the link above for to see the code.

Anyway, I didn't run into the error you encountered. So unless you can give me more detail, I'll probably close the issue in some weeks. :+1:

vguillou commented 8 years ago

Closed as there's no activity here for more than a month, and i couldn't reproduce the issue (but provided a working implementation). Re-open if you think it's necessary !

samcarecho commented 8 years ago

@vguillou I'm really sorry for the delay on replying. The notification emails got lost among many others.

I got it to work properly. Thanks!