Closed kchristin22 closed 2 months ago
@kchristin22 Can you please explain the solution/design as part of the pull-request description?
@kchristin22 Can you please explain the solution/design as part of the pull-request description?
Yes, sorry for delaying this. I added a comment in the issue to facilitate further questions and discussions and added a link to the comment in the description of this PR.
Attention: Patch coverage is 75.86207%
with 14 lines
in your changes missing coverage. Please review.
Project coverage is 93.96%. Comparing base (
6cc83ee
) to head (fd80274
). Report is 17 commits behind head on master.
@kchristin22, what happened here? Something to do with rebase/git?
@vgvassilev I opened a new one to have a clean slate. The old branch is renamed and kept in my repository in case it's ever needed.
Ok, but please do not generally do that since we lose review history. Next time just ping me and I can help you.
@vgvassilev ok, sorry for that. There weren't many comments here, so I thought it would be ok. I'll ping you next time.
This PR solves #1036. CUDA kernels can now be an arg to a
clad::gradient
function and the derived kernels can be executed successfully.Details on issues faced and the final approach can be found here.