Closed gojakuch closed 2 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 94.34%. Comparing base (
6f4b081
) to head (f59ec7d
). Report is 4 commits behind head on master.
clang-tidy review says "All clean, LGTM! :+1:"
clang-tidy review says "All clean, LGTM! :+1:"
clang-tidy review says "All clean, LGTM! :+1:"
I'm marking this as ready for review, although I'll try to resolve a couple more things here before merging. this covers most possible cases (everything not covered by this PR is tracked in the comments in corresponding parts of the code for now). there are multiple commits in this PR, because there were several things that had to be done here, but since it's all Kokkos-related and reviews normally take some time, I put them all into this single PR.
the reason I haven't covered all the possible cases of parallel_reduce
here yet is that I have no idea how to make it work with arbitrary number of reduce parameters in the parallel_reduce
call, since we need to define a pushforward that would take twice as many parameters of correct types for this case. not sure how to go about this for now
@kliegeois, can you take a look?
I will look into this PR very soon.
I tried the PR locally and it generated I think what is expected. I run into a segfault though but I think this is due to a version mismatch. Otherwise the PR looks good to me, thanks!
Have you started looking at the lambda as well?
@kliegeois thanks for the approval
Have you started looking at the lambda as well?
yes, but lambdas need some general rework in Clad. that's on my list though. I've opened some issues to track progress on that and I'll get to it soon.
clang-tidy review says "All clean, LGTM! :+1:"