vgvassilev / clad

clad -- automatic differentiation for C/C++
GNU Lesser General Public License v3.0
291 stars 122 forks source link

Enhance the support of `std::vector` and `std::array` in the fwd mode #1099

Closed gojakuch closed 2 months ago

github-actions[bot] commented 2 months ago

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] commented 2 months ago

clang-tidy review says "All clean, LGTM! :+1:"

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 94.25%. Comparing base (c0c782c) to head (342a61b). Report is 2 commits behind head on master.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/vgvassilev/clad/pull/1099/graphs/tree.svg?width=650&height=150&src=pr&token=9f6Q4em8hE&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Vassil+Vassilev)](https://app.codecov.io/gh/vgvassilev/clad/pull/1099?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Vassil+Vassilev) ```diff @@ Coverage Diff @@ ## master #1099 +/- ## ======================================= Coverage 94.25% 94.25% ======================================= Files 55 55 Lines 8445 8445 ======================================= Hits 7960 7960 Misses 485 485 ```
github-actions[bot] commented 2 months ago

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] commented 2 months ago

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] commented 2 months ago

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] commented 2 months ago

clang-tidy review says "All clean, LGTM! :+1:"

gojakuch commented 2 months ago

LGTM! Can you fix the test:

https://github.com/vgvassilev/clad/blob/c0c782c3c84acf9d0903075bbb42f1b82b876d06/test/ForwardMode/UserDefinedTypes.C#L4

This PR somehow fixes the crashes in debug mode...

so, should I remove this line?

github-actions[bot] commented 2 months ago

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] commented 2 months ago

clang-tidy review says "All clean, LGTM! :+1:"