Closed PetroZarytskyi closed 19 hours ago
clang-tidy review says "All clean, LGTM! :+1:"
clang-tidy review says "All clean, LGTM! :+1:"
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 94.48%. Comparing base (
6753511
) to head (3811bbd
). Report is 1 commits behind head on master.
🚨 Try these New Features:
clang-tidy review says "All clean, LGTM! :+1:"
clang-tidy review says "All clean, LGTM! :+1:"
Now the array is uninitialized.
Now the array is uninitialized.
I think I understand the issue -- can you separate this PR into two separate ones?
clang-tidy review says "All clean, LGTM! :+1:"
This is necessary to ensure type safety.
0
represents a zero vector but is only properly treated as a zero vector when it gets added/subtracted with aclad::array
. Initializing aclad::array
with0
will create not a zero vector but an empty array (with zero elements). To fix this, we needed exceptions for all declarations. We would need to make new exceptions when passing parameters to pushforwards.After merging this PR and #1121, #527 will be fixed automatically.