Closed vaithak closed 4 months ago
clang-tidy review says "All clean, LGTM! :+1:"
clang-tidy review says "All clean, LGTM! :+1:"
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 94.05%. Comparing base (
8039520
) to head (d02359d
).
unknown argument: '-fno-lifetime-dse'
This is a gcc-only flag and when we build the compilation database this becomes a problem. When running the clang-based tools such as clang-tidy we should build clad with clang to avoid propagating such flags.
clang-tidy review says "All clean, LGTM! :+1:"
clang-tidy review says "All clean, LGTM! :+1:"
clang-tidy review says "All clean, LGTM! :+1:"
This is a gcc-only flag and when we build the compilation database this becomes a problem. When running the clang-based tools such as clang-tidy we should build clad with clang to avoid propagating such flags.
Fixed this 👍🏼
With LLVM and Clang >= 16, clang-tidy was returning the following error: