search

vgvassilev / clad

clad -- automatic differentiation for C/C++
GNU Lesser General Public License v3.0
266 stars 113 forks source link

Revert removing clad::array_ref from InterfaceCompatibility.C #929

Closed PetroZarytskyi closed 4 weeks ago

PetroZarytskyi commented 4 weeks ago

clad::array_ref should not have been removed from InterfaceCompatibility.C in #925. The whole point of InterfaceCompatibility.C is to check the compatibility of Clad's interfaces with clad::array_ref.

github-actions[bot] commented 4 weeks ago

clang-tidy review says "All clean, LGTM! :+1:"

codecov[bot] commented 4 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 94.08%. Comparing base (1e88e75) to head (c50a9d9).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/vgvassilev/clad/pull/929/graphs/tree.svg?width=650&height=150&src=pr&token=9f6Q4em8hE&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Vassil+Vassilev)](https://app.codecov.io/gh/vgvassilev/clad/pull/929?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Vassil+Vassilev) ```diff @@ Coverage Diff @@ ## master #929 +/- ## ======================================= Coverage 94.08% 94.08% ======================================= Files 53 53 Lines 7762 7762 ======================================= Hits 7303 7303 Misses 459 459 ```