vgvassilev / clad

clad -- automatic differentiation for C/C++
GNU Lesser General Public License v3.0
266 stars 113 forks source link

Improve finding of higher order custom derivatives #931

Closed vaithak closed 3 weeks ago

vaithak commented 3 weeks ago

Before this change, even if the user had provided a custom derivative of a custom derivative function, Clad couldn't find it.

vgvassilev commented 3 weeks ago

Is that trying to solve maybe even partially #870?

github-actions[bot] commented 3 weeks ago

clang-tidy review says "All clean, LGTM! :+1:"

vaithak commented 3 weeks ago

Is that trying to solve maybe even partially #870?

Yes. In a follow up PRs, that will be solved.

codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 93.72%. Comparing base (1e88e75) to head (1ecf1a2). Report is 4 commits behind head on master.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/vgvassilev/clad/pull/931/graphs/tree.svg?width=650&height=150&src=pr&token=9f6Q4em8hE&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Vassil+Vassilev)](https://app.codecov.io/gh/vgvassilev/clad/pull/931?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Vassil+Vassilev) ```diff @@ Coverage Diff @@ ## master #931 +/- ## ========================================== - Coverage 94.08% 93.72% -0.36% ========================================== Files 53 54 +1 Lines 7762 7782 +20 ========================================== - Hits 7303 7294 -9 - Misses 459 488 +29 ``` | [Files](https://app.codecov.io/gh/vgvassilev/clad/pull/931?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Vassil+Vassilev) | Coverage Δ | | |---|---|---| | [include/clad/Differentiator/CladUtils.h](https://app.codecov.io/gh/vgvassilev/clad/pull/931?src=pr&el=tree&filepath=include%2Fclad%2FDifferentiator%2FCladUtils.h&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Vassil+Vassilev#diff-aW5jbHVkZS9jbGFkL0RpZmZlcmVudGlhdG9yL0NsYWRVdGlscy5o) | `100.00% <ø> (ø)` | | | [lib/Differentiator/CladUtils.cpp](https://app.codecov.io/gh/vgvassilev/clad/pull/931?src=pr&el=tree&filepath=lib%2FDifferentiator%2FCladUtils.cpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Vassil+Vassilev#diff-bGliL0RpZmZlcmVudGlhdG9yL0NsYWRVdGlscy5jcHA=) | `92.85% <100.00%> (-0.11%)` | :arrow_down: | | [lib/Differentiator/DerivativeBuilder.cpp](https://app.codecov.io/gh/vgvassilev/clad/pull/931?src=pr&el=tree&filepath=lib%2FDifferentiator%2FDerivativeBuilder.cpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Vassil+Vassilev#diff-bGliL0RpZmZlcmVudGlhdG9yL0Rlcml2YXRpdmVCdWlsZGVyLmNwcA==) | `100.00% <100.00%> (+0.98%)` | :arrow_up: | ... and [4 files with indirect coverage changes](https://app.codecov.io/gh/vgvassilev/clad/pull/931/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Vassil+Vassilev) | [Files](https://app.codecov.io/gh/vgvassilev/clad/pull/931?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Vassil+Vassilev) | Coverage Δ | | |---|---|---| | [include/clad/Differentiator/CladUtils.h](https://app.codecov.io/gh/vgvassilev/clad/pull/931?src=pr&el=tree&filepath=include%2Fclad%2FDifferentiator%2FCladUtils.h&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Vassil+Vassilev#diff-aW5jbHVkZS9jbGFkL0RpZmZlcmVudGlhdG9yL0NsYWRVdGlscy5o) | `100.00% <ø> (ø)` | | | [lib/Differentiator/CladUtils.cpp](https://app.codecov.io/gh/vgvassilev/clad/pull/931?src=pr&el=tree&filepath=lib%2FDifferentiator%2FCladUtils.cpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Vassil+Vassilev#diff-bGliL0RpZmZlcmVudGlhdG9yL0NsYWRVdGlscy5jcHA=) | `92.85% <100.00%> (-0.11%)` | :arrow_down: | | [lib/Differentiator/DerivativeBuilder.cpp](https://app.codecov.io/gh/vgvassilev/clad/pull/931?src=pr&el=tree&filepath=lib%2FDifferentiator%2FDerivativeBuilder.cpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Vassil+Vassilev#diff-bGliL0RpZmZlcmVudGlhdG9yL0Rlcml2YXRpdmVCdWlsZGVyLmNwcA==) | `100.00% <100.00%> (+0.98%)` | :arrow_up: | ... and [4 files with indirect coverage changes](https://app.codecov.io/gh/vgvassilev/clad/pull/931/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Vassil+Vassilev)
github-actions[bot] commented 3 weeks ago

clang-tidy review says "All clean, LGTM! :+1:"