Closed PetroZarytskyi closed 3 months ago
clang-tidy review says "All clean, LGTM! :+1:"
clang-tidy review says "All clean, LGTM! :+1:"
Attention: Patch coverage is 91.66667%
with 1 line
in your changes missing coverage. Please review.
Project coverage is 93.75%. Comparing base (
4ebd1af
) to head (d61d0a4
).
clang-tidy review says "All clean, LGTM! :+1:"
clang-tidy review says "All clean, LGTM! :+1:"
clang-tidy review says "All clean, LGTM! :+1:"
This PR removes all pairs of goto/label statements with nothing in between:
Obviously, this bit of code doesn't do anything. Such cases make up the majority of goto uses in Clad. The idea in this PR is to check whether the corresponding return statement is the last statement in the function's body. If it is, there's no need to create a goto statement. Before this PR, Clad tests contained 328 goto stmts, now they only contain 21.
Fixes #526.