Open rohanjulka19 opened 2 weeks ago
@rohanjulka19, do you mind addressing the clang-tidy complaints where relevant?
hi, yeah will address these clang-tidy issues, actually i got stuck on the loop condition differentiation issue (once again) https://github.com/vgvassilev/clad/pull/818. But now I am fixing that one, once I push that fix will address these then.
@vgvassilev I have fixed most of the suggestion, the above four I don't think needs to be addressed.
@vgvassilev I have fixed most of the suggestion, the above four I don't think needs to be addressed.
The include protector suggestions seem good. Looks like the new tape has a problem with cuda.
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 93.94%. Comparing base (
8749404
) to head (38fdfb3
).
The include protector suggestions seem good. Looks like the new tape has a problem with cuda.
Have changed the include protector to align with the suggestion. The cuda test is passing but I am not sure if it will work when this runs on more than one thread in parallel
Currently I have added a basic implementation of tape data structure with connected lists/slabs. It is more or less similar to current tape data strucutre I copied a lot of code just added blocks and only added the functionality which I feel is needed for reverse mode.
Right now NumericalDiff also uses tape so I defined two types one is "tape" which points to the new tape implementation and "old_tape" which points to current tape data strcuture being used.
Tests are running fine for the new implementation.
These are the benchmarks for old_tape and new_tape.
LastTest-new-tape.log LastTest-tape.log
Fixes - #793