search

vgvassilev / hepcon-config

Register your indico event to HEPCon
https://vgvassilev.github.io/hepcon/
Apache License 2.0
0 stars 4 forks source link

Add dark mode support #43

Open matthewfeickert opened 2 years ago

matthewfeickert commented 2 years ago

Hi. On HEPCon v3.1.7 the choices for color schemes make menus very difficult to read at all on iOS

Image from iOS

Can these be revised? As is, the color schemes make the text almost impossible to read for people with any sort of vision impairment.

mvassilev commented 2 years ago

Hi, thank you for reporting. Indeed if you switch to Dark mode it looks like that. Will be fixed asap.

Martin

mvassilev commented 2 years ago

@matthewfeickert there is the 3.1.8 version where I have included a quick fix for the dark mode - the app always shows in light mode. While this solution is not ideal, the texts in the app are readable and it would give me enough time to prepare a new version with a real dark mode.

matthewfeickert commented 2 years ago

Indeed, much improved! Thanks @mvassilev!

image

matthewfeickert commented 2 years ago

While this solution is not ideal, the texts in the app are readable and it would give me enough time to prepare a new version with a real dark mode.

As seen above, the implementation in v3.1.8 is sufficient to provide visible text on iOS when the phone is in dark mode. I've renamed this Issue and will leave it open for the dev team to close once official dark mode support has been added, but thanks for being quite responive @mvassilev!

mvassilev commented 2 years ago

While this solution is not ideal, the texts in the app are readable and it would give me enough time to prepare a new version with a real dark mode.

As seen above, the implementation in v3.1.8 is sufficient to provide visible text on iOS when the phone is in dark mode. I've renamed this Issue and will leave it open for the dev team to close once official dark mode support has been added, but thanks for being quite responive @mvassilev!

You are welcome and thanks for reporting!