search

vgwb / Antura_arabic

winner of the EduApp4Syria international initiative, the learning game "Antura and the Letters (Arabic)" teaches arabic kids how to read and write. Complete open source Unity project.
http://www.antura.org
Other
54 stars 26 forks source link

[MakeFriends] Sometimes the correct letters do not highlight in the words #719

Open FrancyCavallari opened 6 years ago

FrancyCavallari commented 6 years ago

Usually the correct letter get highlighted in both words when you drop the right answer... ... but sometimes (1 out of 10) the letters do not highlight.

Here you have an example... image ... and it's log: [New Round] Word 1: رﺰﺠﻟا, Word 2: ﺖﻳﺰﻟا Common: ـﺰَ, Uncommon: ـﺶّ / ـﺺّ / غِ / لَ / ﺻَ

NOTE: I think this problem appeared with the new management of Shaddah but I was able to reproduce it both on words with and without Shaddah.

FrancyCavallari commented 6 years ago

The more I test and the more thnk it's NOT related with the new Shaddah management!

FrancyCavallari commented 6 years ago

Copying here the comments that were wrongly put on #585

@CatmanIta wrote: Issue seems to be related to ArabicAlphabetHelper.FindLetter.

MakeFriends calls ArabicAlphabetHelper.FindLetter(Core.AppManager.I.DB, word.Data, markedLetter.Data, true));

I suspect that the arabic alphabet helper is not correctly finding the given letter with the correct form when splitting.

@FrancyCavallari wrote: I found a warning in the Log: Cannot parse letter ّ (0651) in اَﻟﺰَّﻳْﺖ UnityEngine.Debug:Log(Object) Antura.Helpers.ArabicAlphabetHelper:AnalyzeArabicString(DatabaseObject, String, Boolean, Boolean) (at Assets/_app/_scripts/Language/ArabicAlphabetHelper.cs:299) Antura.Helpers.ArabicAlphabetHelper:SplitWord(DatabaseManager, WordData, Boolean, Boolean) (at Assets/_app/_scripts/Language/ArabicAlphabetHelper.cs:138) Antura.Helpers.ArabicAlphabetHelper:FindLetter(DatabaseManager, WordData, LetterData, Boolean) (at Assets/_app/_scripts/Language/ArabicAlphabetHelper.cs:120) Antura.LivingLetters.LivingLetterController:MarkLetters(List1, Color) (at Assets/_app/_scripts/LivingLetter/LivingLetterController.cs:473) Antura.Minigames.MakeFriends.MakeFriendsLivingLetter:MarkLetters(List1, Color) (at Assets/_games/MakeFriends/_scripts/MakeFriendsLivingLetter.cs:329) Antura.Minigames.MakeFriends.c__Iterator3:MoveNext() (at Assets/_games/MakeFriends/_scripts/MakeFriendsGame.cs:418) UnityEngine.MonoBehaviour:StartCoroutine(IEnumerator) Antura.Minigames.MakeFriends.MakeFriendsGame:EndRound(Boolean) (at Assets/_games/MakeFriends/_scripts/MakeFriendsGame.cs:388) Antura.Minigames.MakeFriends.MakeFriendsGame:OnLetterChoiceSelected(LetterChoiceController) (at Assets/_games/MakeFriends/_scripts/Ma

FrancyCavallari commented 6 years ago

I also had the issue without any warning like in this case: image

FrancyCavallari commented 6 years ago

@StefanoCecere I added you to this issue since it may be related to "shaddah"... if we have time we have a look at it