search

vhakulinen / gnvim

GUI for neovim, without any web bloat
MIT License
1.85k stars 69 forks source link

Layout issues with floating windows made by Coc #105

Closed Avi-D-coder closed 4 years ago

Avi-D-coder commented 5 years ago

Screenshot_20190905_175651

smolck commented 5 years ago

Hello! Thanks for reporting this issue! I believe it is a duplicate of #85 (I’ve been seeing it with the new pango 1.44), which does have a workaround: https://github.com/vhakulinen/gnvim/issues/85#issuecomment-527200720.

Would you mind either trying that diff or downgrading pango to v1.43 to see if that fixes the issue? Note that there are black lines (more pronounced) in the second image of the opening comment of #85.

I’m not sure what’s causing the layout issue, but I don’t think it’s caused by a lack of multigrid support (although I could be wrong). Please don’t hesitate to open an issue for that; I’m interested to see what’s causing it and would be happy to help with a fix.

Avi-D-coder commented 5 years ago

Yep your right the lines do look like a duplicate. Will test to make sure latter. Thanks

vhakulinen commented 5 years ago

Could you try with --disable-ext-popupmenu?

Avi-D-coder commented 5 years ago

--disable-ext-popupmenu does appear to fix the layout.

vhakulinen commented 4 years ago

Note to self: there seems to be nvim_ui_pum_set_bounds function which might help with this.

vhakulinen commented 4 years ago

Can you try with this branch? https://github.com/vhakulinen/gnvim/tree/feature/report-pum-bounds

last-partizan commented 4 years ago

With --disable-ext-popupmenu coc popups placement is correct.

image

With default gnvim popupmenu i get overlapping: image

last-partizan commented 4 years ago

Oh, and i get LOTS of these messages in console:

[2020-08-22T11:05:57Z ERROR gnvim::ui::popupmenu::popupmenu] Failed to set pum bounds: Error processing request: 0 - 'Invalid method: nvim_ui_pum_set_bounds')
vhakulinen commented 4 years ago

Can you try with the latest nvim master? nvim_ui_pum_set_bounds probably is only in master.

last-partizan commented 4 years ago

@vhakulinen yes, with neovim-nightly it works as expected!

image