search

vhakulinen / gnvim

GUI for neovim, without any web bloat
MIT License
1.86k stars 68 forks source link

Installing on OSX? #110

Closed leeola closed 5 years ago

leeola commented 5 years ago

I'm having trouble installing gnvim on OSX due to the libwebkit2gtk requirement. How crucial is that to operating gnvim, and could a feature be added to opt out of that requirement?

smolck commented 5 years ago

@vhakulinen Isn’t libwebkit2gtk used to render markdown in the cursor tooltip? Or is it used in other places too?

badosu commented 5 years ago

Does Rust support optional dependencies?

Edit: Seems like it. I think apart from the build process and feature handling adjustments, should be quite straightforward

BTW, I've never seen well formatted markdown on gnvim, when does it happen?

smolck commented 5 years ago

Does Rust support optional dependencies?

Edit: Seems like it. I think apart from the build process and feature handling adjustments, should be quite straightforward

Hopefully it can be done without too much boilerplate (e.g. #cfg(...) statements everywhere). Worst case scenario we could maybe make a separate, 'bare bones' branch of GNvim or something.

BTW, I've never seen well formatted markdown on gnvim, when does it happen?

I believe it happens when hovering over something with gnvim-lsp installed; see bottom of this page in the wiki and cursor_tooltip.rs.

smolck commented 5 years ago

@leeola Maybe https://github.com/vhakulinen/gnvim/issues/8#issuecomment-517421794 can help you? (Until we find a way to remove the webkit requirement, when necessary, in GNvim)

leeola commented 5 years ago

I actually found that before posting (during searching/etc), but didn't even try it due to it not working for the OP haha. Apparently it took over 2 hours, and still failed. I didn't bother heh.

leeola commented 5 years ago

Appreciate the discussion all. I should note that this issue is not widely important to me (or I'd offer to help), so don't try too much on my account. I just wanted to give Gnvim a try, and thought I was missing something stupid. Thanks :)

vhakulinen commented 5 years ago

Adding the webkit2gtk dependency behind a (compile time) feature flag should be possible. PRs for this are welcome. Webkit is used to display markdown documents on the cursor tooltip.

Closing this as duplicate of #8.

Lythenas commented 5 years ago

I'm working on a PR for this. I haven't worked with rust for a while and this seems easy to do.

kropper commented 5 years ago

Yes, it builds now without error! :-)

However, after starting it, fonts are pretty messed up and the insert cursor cuts characters in half. Are there any settings recommended for running on macOS?

vhakulinen commented 5 years ago

Make sure you're using (and have available) a monospace font. Can you post a screenshot (or alternatively hop on the gnvim gitter channel)?