search

vhakulinen / gnvim

GUI for neovim, without any web bloat
MIT License
1.86k stars 68 forks source link

Wrong version number in tarball #140

Closed Hawk777 closed 1 year ago

Hawk777 commented 4 years ago

I went to the Releases page on Github and downloaded the latest release tarball (0.1.6). After extracting it, in Cargo.toml, the version field is set to 0.1.0.

vhakulinen commented 4 years ago

Gnvim doesn't use the version in Cargo.toml. Our build script extracts the version number from git tags (on build).

Hawk777 commented 4 years ago

git tags

Which don’t exist if you download a tarball. But feel free to close this ticket if you don’t consider the tarballs on your Releases page to be an acceptable way to get package sources.

vhakulinen commented 4 years ago

This current way has proven to be a problem with others too, so I'll probably adjust my release flow to add the version number into the Cargo.toml file.

vhakulinen commented 1 year ago

Gnvim was rewritten from ground up for gtk4, and the current build file doesn't try access git anymore for the version number. If the problem persists, feel free to reopen this issue.