search

vhakulinen / gnvim

GUI for neovim, without any web bloat
MIT License
1.84k stars 69 forks source link

feedback & quit_confirm feature request #189

Closed ttytm closed 1 year ago

ttytm commented 2 years ago

Hello,

A little additional data safety feature I think would be awesome is triggering a quit_confirm when OS-closing the window. Causing a prompt when trying to close the client while having unsaved buffers. Maybe as an option or the default behavior. What do you think about such a thing?

And I'm coincidentally seeing the good news that it'll be ported to gtk4. Man, thanks for developing such a great client! What I always liked most about gnvim that it had the most flawless implementation of smooth scrolling. Coconut oily smooth animations and no jumpiness when scrolling over folds. Makes it a pleasure to use. Imho none of the other nvim UIs can compete with this.

Sending love and blessings

vhakulinen commented 2 years ago

Would sending :qa to nvim when you press the close button do the trick? I think that would be the "correct" thing to do.

And thank you for the kind words.

ttytm commented 2 years ago

Hello, Nice to read your reply. Yes, that's what I thought of! System-closing a window I usually do with meta+q. A workaround I tried to achieve this, was to integrate the gdk superkey modifier into the modifier keylist and then to map this comb inside vim to :qa. Unfortunately that didn't work out. Also, this is probably more complicated than what it needs to be for this simple purpose.

dbarnett commented 2 years ago

Looks like confirm on close was previously requested in #147.

ttytm commented 2 years ago

Looks like confirm on close was previously requested in #147.

Oh, exactly. Must have missed that. And like you mentioned in the other issues there are multiple of those requests. Hope it gets implemented soon. Unfortunately I currently don't have the time to work my way into how to apply that into the window close event.

vhakulinen commented 1 year ago

Closing as duplicate of #147.