Improve lyrics search engine

vhaudiquet / blade-player

Android music player that plays from local library, Spotify or Deezer

GNU General Public License v3.0

68 stars 12 forks source link

Improve lyrics search engine #37

Open ChristophyBarth opened 5 years ago

ChristophyBarth commented 5 years ago

Expected behavior

I expected the lyrics of any music I played to be displayed so I could sing along with the flow of the music.

Actual behavior

Once I click on the 'lyrics' option, no lyric is displayed. Except for a feedback that said “Song lyric not found. Sorry...” or “Error occurred while parsing lyrics.”

How to reproduce

Download and install the latest version of the Blade Player.
Launch the application
Start playing a music
Click on the music (at the bottom of your screen) which has started playing
Click on the three vertically arranged dots around the bottom of the screen
Then click on the 'Lyrics' option
See error

App version: 1.4.0.1
Device: Gionee f100s
Operating system: android version 6.0

Recording of the bug

https://youtu.be/r0YrAjsCNoo

vhaudiquet commented 5 years ago

To find the lyrics of a song, Blade uses it's metadata : song title, album, and artist. I see on the recording that your song does not seem to have the accurate metadata. Imagine searching the lyrics for "Statement NF Lyrics 128K MP3 by Unknown Artist in SnaptubeAudio album" in a database : you would get not result. Well that's basically what Blade does. In order for this feature to work, you need to set metadata accurately.

ChristophyBarth commented 5 years ago

I have tried it even with 5 different musics but the lyrics won't show.

ChristophyBarth commented 5 years ago

Just now, I tried playing another song by NF titled WHY. Even with the right information's, 20190418-200226

here's the result I got 👇 20190418-200209 . . . Other music players would use this information to get the lyrics (I'm sure because I did it lately with another app)

ChristophyBarth commented 5 years ago

@valou3433, will you do anything about this? Please

vhaudiquet commented 5 years ago

Alright, i'm gonna try to improve the lyrics searching engine, but this might be really tricky because i would need partnerships with lyrics providers... For now i'm using Genius API and doing a little magic (which sometimes fail, hence the "lyrics parsing error") to get lyrics. Maybe another API could be better ? Anyway, i'll look into it.