vhaudiquet / blade-player

Android music player that plays from local library, Spotify or Deezer
GNU General Public License v3.0
67 stars 12 forks source link

Add to playlist function does nothing . #5

Closed kodeblacc closed 6 years ago

kodeblacc commented 6 years ago

Expected behavior

Blade-player offers the option to add tracks to playlist so it is expected that when the option is selected, the track is added to a playlist either automatically created since the app currently has no option to manually create playlist or allow users assign tracks to a playlist manually.

Actual behavior

\When the add to playlist option is selected, there is no toast message signifying if the operation was successful and the song is not added to any available playlist neither is a new playlist created.

How to reproduce

vhaudiquet commented 6 years ago

I'm sorry if you missunderstood the function, 'add to playlist' is actually 'add to current playlist', it adds the artist/album/song you selected to the current playlist only for this play session. I'll add real playlist edition on future updates, but to do that i'll need to implement local storage/spotify/deezer writing on user data, which i plan to do after i cleaned up the user library loading. Anyway you're right i need to add a toast message (and to rename the button), without that it really looks like doing nothing :) Also just to let you know i'm happy to get issues like theses, so if you find bugs using Blade, dont worry you can always tell me, but remember that the project is still in pre-release (i started it 2 weeks ago).

kodeblacc commented 6 years ago

I tried the way you explained. The song is added to the current playlist where I'm playing a song from. It wasn't added though. Is it a bug?