search

vhbb / cmssw

CMS Offline Software
cms-sw.github.io/cmssw
4 stars 5 forks source link

Vhbb heppy80 x factorized jec #567

Closed jpata closed 7 years ago

jpata commented 7 years ago

First attempt at #566. I'll take a look at why I have some Lorenzo's commits in here as well later.

jpata commented 7 years ago

Note, needed to revert GT from Spring16_25nsV6_DATA while waiting for JERC input.

jpata commented 7 years ago

I've checked for closure (seems OK, but not perfect).

See attached: jec_factorize.html.zip

jpata commented 7 years ago

@bianchini's commits are included here because PR https://github.com/vhbb/cmssw/pull/556 is not yet merged, I've had to merge it locally for the ttH analysis. Lorenzo, can you perhaps merge that PR so I can rebase this one cleanly?

bianchini commented 7 years ago

Ok, done!

arizzi commented 7 years ago

did you also update vhbb.py / vhbbobj.py to store them? (it seems not to me but I may have missed it)

jpata commented 7 years ago

@arizzi the JECs are stored in autophobj.py directly in heppy, but possibly we want to put it in a different place in case the list of factorizations is configured at runtime.

arizzi commented 7 years ago

does it mean that automatically every Heppy use will get them? We should make this not default-on because many heppy user do not care (and it increase sizebly the ntuple size I imagine)

arizzi commented 7 years ago

thanks. We should also create a PR against central colin branch (that is probably ahead of us)

jpata commented 7 years ago

Superceded by https://github.com/vhbb/cmssw/pull/570 and https://github.com/cbernet/cmssw/pull/78