search

vhbb / cmssw

CMS Offline Software
cms-sw.github.io/cmssw
4 stars 5 forks source link

Update subjet handling #592

Closed gkasieczka closed 7 years ago

gkasieczka commented 7 years ago

Updated JEC and uncertainty for subjets.

Still need to test with 8_0_21.

arizzi commented 7 years ago

let me know once tested so that I can merge

jpata commented 7 years ago

@gkasieczka could you cherry-pick https://github.com/jpata/cmssw/commit/59f0257d4dc7cdf29eadb2f05ede0f88ff71f1df?

This solves the accidental reversion of the JetReCalibrator that we discussed with @arizzi privately. I'll make a separate PR against cbernet/heppy_8_0_19, but since vhbb is already 8_0_21, it's easier to make just one jet-related PR here, I think.

arizzi commented 7 years ago

can I merge then? or should I wait the cherry-pick?

gkasieczka commented 7 years ago

The cherry pick is in.

The output looks good, but I'm getting lots of errors from JetCorrectionUncertainty/SimpleJetCorrectionUncertainty at the moment.

arizzi commented 7 years ago

you mean this?

%MSG-e SimpleJetCorrectionUncertainty: bin variables out of range %MSG

I see that too... @jpata can you have a look? I see them also updating the GT

jpata commented 7 years ago

I started to have a look a little while ago

gkasieczka commented 7 years ago

Yes, that's what I mean. Though it does not seem to be caused by @jpata's extra lines.

gkasieczka commented 7 years ago

Latest commit (cc08685) fixes the issue

jpata commented 7 years ago

output seems OK.

jpata commented 7 years ago

The heppy-side version of the fix incorporated here is https://github.com/cbernet/cmssw/pull/82