search

vhbb / cmssw

CMS Offline Software
cms-sw.github.io/cmssw
4 stars 5 forks source link

Add spring16 el mva #624

Closed capalmer85 closed 7 years ago

capalmer85 commented 7 years ago

@arizzi This doesn't work quite yet.

arizzi commented 7 years ago

any news here? still need help?

capalmer85 commented 7 years ago

I looked a little deeper yesterday and they are using a different module now for the mva reader. This PR must be redone. I'm planning on giving it a try this afternoon.

FYI, some files will eventually appear in CMSSW 80X, but I will have to add them in the mean time.

On Tue, Jan 17, 2017 at 9:46 AM, arizzi notifications@github.com wrote:

any news here? still need help?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/vhbb/cmssw/pull/624#issuecomment-273187636, or mute the thread https://github.com/notifications/unsubscribe-auth/AFKqhxtyfU_-NWgoqdXF5MCu7i7TOd0kks5rTNRTgaJpZM4LjQsM .

arizzi commented 7 years ago

you can merge their PR (in our git) that adds the file if one exists already!

On Tue, Jan 17, 2017 at 3:53 PM, capalmer85 notifications@github.com wrote:

I looked a little deeper yesterday and they are using a different module now for the mva reader. This PR must be redone. I'm planning on giving it a try this afternoon.

FYI, some files will eventually appear in CMSSW 80X, but I will have to add them in the mean time.

On Tue, Jan 17, 2017 at 9:46 AM, arizzi notifications@github.com wrote:

any news here? still need help?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/vhbb/cmssw/pull/624#issuecomment-273187636, or mute the thread https://github.com/notifications/unsubscribe-auth/AFKqhxtyfU_- NWgoqdXF5MCu7i7TOd0kks5rTNRTgaJpZM4LjQsM .

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/vhbb/cmssw/pull/624#issuecomment-273190009, or mute the thread https://github.com/notifications/unsubscribe-auth/AEyilkVVKYt7BSrxfasHGLesYyFEMFtqks5rTNXVgaJpZM4LjQsM .

capalmer85 commented 7 years ago

ah ok. I'll do that then.

On Tue, Jan 17, 2017 at 9:57 AM, arizzi notifications@github.com wrote:

you can merge their PR (in our git) that adds the file if one exists already!

On Tue, Jan 17, 2017 at 3:53 PM, capalmer85 notifications@github.com wrote:

I looked a little deeper yesterday and they are using a different module now for the mva reader. This PR must be redone. I'm planning on giving it a try this afternoon.

FYI, some files will eventually appear in CMSSW 80X, but I will have to add them in the mean time.

On Tue, Jan 17, 2017 at 9:46 AM, arizzi notifications@github.com wrote:

any news here? still need help?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/vhbb/cmssw/pull/624#issuecomment-273187636, or mute the thread https://github.com/notifications/unsubscribe-auth/AFKqhxtyfU_- NWgoqdXF5MCu7i7TOd0kks5rTNRTgaJpZM4LjQsM .

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/vhbb/cmssw/pull/624#issuecomment-273190009, or mute the thread https://github.com/notifications/unsubscribe-auth/ AEyilkVVKYt7BSrxfasHGLesYyFEMFtqks5rTNXVgaJpZM4LjQsM .

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/vhbb/cmssw/pull/624#issuecomment-273191412, or mute the thread https://github.com/notifications/unsubscribe-auth/AFKqh5hn03C3hRxOjpLSJtJDb04CzNH5ks5rTNbogaJpZM4LjQsM .

capalmer85 commented 7 years ago

640 supersedes