[READY] Add shutdown handler

micbou commented 7 years ago

Adding a shutdown endpoint makes it possible to cleanly exit JediHTTP on Windows. This is implemented the same way as in ycmd. See PR https://github.com/Valloric/ycmd/pull/282 for more detail.

I made the following changes to the setup and teardown methods of the end-to-end tests:

start the server with logging level set to debug;
wait for the server to be ready before each test;
use the new shutdown handler to stop the server after each test;
write the output of the server to nosetests stdout at the end of each test.

This change is

micbou commented 7 years ago

@vheon You seem to be busy so I'll go ahead and merge this PR and https://github.com/vheon/JediHTTP/pull/40.

@zzbot r+

Reviewed 7 of 7 files at r1, 1 of 1 files at r2, 2 of 2 files at r3. Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

zzbot commented 7 years ago

:pushpin: Commit 430fe64 has been approved by micbou

zzbot commented 7 years ago

:hourglass: Testing commit 430fe64bb360ebee47cb6e679cddb68c018bae43 with merge 8f2e44c6494af6922ad3a3bfdd173bd5f311ab22...

zzbot commented 7 years ago

:sunny: Test successful - status-appveyor, status-travis Approved by: micbou Pushing 8f2e44c6494af6922ad3a3bfdd173bd5f311ab22 to master...

vheon / JediHTTP

[READY] Add shutdown handler #39