vheon / JediHTTP

Simple http wrapper around jedi
Apache License 2.0
40 stars 9 forks source link

[READY] Fix nose --ignore-files option #42

Closed micbou closed 7 years ago

micbou commented 7 years ago

We were only ignoring the file . instead of all files starting with a dot when running the tests. With this PR, we also ignore the setup.py file since:

Thanks to @yan12125.


This change is Reviewable

codecov-io commented 7 years ago

Codecov Report

Merging #42 into master will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #42   +/-   ##
=======================================
  Coverage   94.48%   94.48%           
=======================================
  Files           8        8           
  Lines         308      308           
=======================================
  Hits          291      291           
  Misses         17       17
vheon commented 7 years ago

:lgtm: @zzbot r+


Reviewed 1 of 1 files at r1. Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

zzbot commented 7 years ago

:pushpin: Commit 57a5110 has been approved by vheon

zzbot commented 7 years ago

:hourglass: Testing commit 57a511069d88a8263c27e99308e40b4761d95dfb with merge 3d3dcf4118181688d55463dda53dee386cfbfe4f...

zzbot commented 7 years ago

:sunny: Test successful - status-appveyor, status-travis Approved by: vheon Pushing 3d3dcf4118181688d55463dda53dee386cfbfe4f to master...

yan12125 commented 7 years ago

Thanks for this!