vheon / JediHTTP

Simple http wrapper around jedi

Apache License 2.0

40 stars 9 forks source link

Update Jedi to 0.12.0, parso to 0.2.0 and drop support for Python 2.6 #53

Closed yan12125 closed 6 years ago

yan12125 commented 6 years ago

From https://github.com/davidhalter/jedi/blob/master/CHANGELOG.rst#0120-2018-04-15:

Remove Python 2.6 support

So I think it's time to remove Python 2.6 support in JediHTTP, too.

Not sure if you want to keep compatibility for Python 2.7.x < 2.7.7. According to Repology data, among major distributions, Ubuntu 14.04 (ships 2.7.6) and CentOS 7 (ships 2.7.5) are affected. I assume you don't as you test against 2.7.13 on Travis.

This change is

codecov-io commented 6 years ago

Codecov Report

Merging #53 into master will increase coverage by 0.41%. The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #53      +/-   ##
==========================================
+ Coverage   95.22%   95.63%   +0.41%     
==========================================
  Files           9        9              
  Lines         356      344      -12     
==========================================
- Hits          339      329      -10     
+ Misses         17       15       -2

micbou commented 6 years ago

Thanks for the PR but I think we are going to drop JediHTTP and use Jedi directly in ycmd since Jedi introduced two important features that obsoletes JediHTTP:

Jedi is now able to return completions for a different Python than the one running it;
Jedi shouldn't crash anymore when importing compiled modules.

Most of the work is already done in this branch. Feel free to try it out.

Review status: 0 of 10 files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

yan12125 commented 6 years ago

Awesome work - the update-jedi branch works like a charm. It's great to hear that I don't have to run two servers for Python completions.

Now this PR is not necessary. Closing.