search

vhf / free-programming-books-lint

A rudimentary Markdown linter based on remark-lint for the free-programming-books project.
31 stars 12 forks source link

languages that aren't linted #14

Closed eshellman closed 3 years ago

eshellman commented 3 years ago

Here is the current list of languages covered in the F-P-B repo:

'ar', 'az', 'bg', 'bl', 'cs', 'de', 'dk', 'en', 'es', 'et', 'fa_IR', 'fi', 'fr', 'gr', 'hi', 'hu', 'id', 'it', 'ja', 'ko', 'kk', 'my', 'nl', 'no', 'pl', 'pt_BR', 'pt_PT', 'ro', 'ru', 'se', 'sk', 'ta', 'th', 'tr', 'ua', 'vi', 'zh',

eshellman commented 3 years ago

15 of these languages are not considered in the linter.

eshellman commented 3 years ago

Is there anything more to do than add these in lint.js?

vhf commented 3 years ago

I don't think so, it should just work. There's just one thing to keep in mind: alphabetical ordering isn't something that works with all languages and you'll most probably need advice from native speakers. For instance to my knowledge alphabetically sorting Japanese words is an unsolved problem. The way it will be enforced here is how JavaScript implements it, and the result could very well seem weird/unnatural/unpredictable to Japanese speakers.

eshellman commented 3 years ago

I think that's ok

eshellman commented 3 years ago

so I tried running this locally (macOS, node 15.6) on the courses list and it reported errors for ko, ru, and vi, which aren't in the list. So I'm confused. (and not much experience with node.)